Syntax error

[Artur]

Hej.

Jag använder 000webhost och PHP.

När jag går in på min websida http://www.rismakalogin.netai.net/register.php så får jag ett fel

Kolla på länken så kan ni se felet.

[Cecilia]

Menar du följande meddelande?

Website Under Review

 

You are seeing this page because the system administrator of 000webhost.com is currently checking this website for malicious content. This redirect page will be removed once we finish manually checking all files on this account. Since we check over 100 websites per day, it can take about 2-4 hours to complete. If you are the owner of this website, you will get an email confirmation once it's done. If you are a visitor, please come back later.

[Artur]

Nej!

 

det står ungeför PHP error

 

000webhost is not allowd to connect to this SQL server

[Artur]

Löste det felet, men nu står det Parse error: syntax error, unexpected T_DNUMBER in /home/a1532196/public_html/include/database.php on line 24

 

[Cecilia]

Nu kan jag inte vare sig PHP eller SQL, men utan att veta mer om ditt system så är det omöjligt för någon att kunna hjälpa dig.

Vilken databas?

Hur ser database.php ut?

[Artur]

Det är ett inloggningssystem som jag fått av en på internet, database.php ser ut så här.

<?
/**
* Database.php
* 
* The Database class is meant to simplify the task of accessing
* information from the website's database.
*
* Written by: Jpmaster77 a.k.a. The Grandmaster of C++ (GMC)Detta system ägs ej av Rismaka
* Last Updated: August 17, 2004
*/
include("constants.php");

class MySQLDB
{
var $connection; //The MySQL database connection
var $num_active_users; //Number of active users viewing site
var $num_active_guests; //Number of active guests viewing site
var $num_members; //Number of signed-up users
/* Note: call getNumMembers() to access $num_members! */

/* Class constructor */
function MySQLDB(){
/* Make connection to database */
$this->connection = mysql_connect(DB_SERVER, DB_USER, DB_PASS) or die(mysql_error());
mysql_select_db(DB_NAME, $this->connection) or die(mysql_error());

/**
* Only query database to find out number of members
* when getNumMembers() is called for the first time,
* until then, default value set.
*/
$this->num_members = -1;

if(TRACK_VISITORS){
/* Calculate number of users at site */
$this->calcNumActiveUsers();

/* Calculate number of guests at site */
$this->calcNumActiveGuests();
}
}

/**
* confirmUserPass - Checks whether or not the given
* username is in the database, if so it checks if the
* given password is the same password in the database
* for that user. If the user doesn't exist or if the
* passwords don't match up, it returns an error code
* (1 or 2). On success it returns 0.
*/
function confirmUserPass($username, $password){
/* Add slashes if necessary (for query) */
if(!get_magic_quotes_gpc()) {
$username = addslashes($username);
}

/* Verify that user is in database */
$q = "SELECT password FROM ".TBL_USERS." WHERE username = '$username'";
$result = mysql_query($q, $this->connection);
if(!$result || (mysql_numrows($result) < 1)){
return 1; //Indicates username failure
}

/* Retrieve password from result, strip slashes */
$dbarray = mysql_fetch_array($result);
$dbarray['password'] = stripslashes($dbarray['password']);
$password = stripslashes($password);

/* Validate that password is correct */
if($password == $dbarray['password']){
return 0; //Success! Username and password confirmed
}
else{
return 2; //Indicates password failure
}
}

/**
* confirmUserID - Checks whether or not the given
* username is in the database, if so it checks if the
* given userid is the same userid in the database
* for that user. If the user doesn't exist or if the
* userids don't match up, it returns an error code
* (1 or 2). On success it returns 0.
*/
function confirmUserID($username, $userid){
/* Add slashes if necessary (for query) */
if(!get_magic_quotes_gpc()) {
$username = addslashes($username);
}

/* Verify that user is in database */
$q = "SELECT userid FROM ".TBL_USERS." WHERE username = '$username'";
$result = mysql_query($q, $this->connection);
if(!$result || (mysql_numrows($result) < 1)){
return 1; //Indicates username failure
}

/* Retrieve userid from result, strip slashes */
$dbarray = mysql_fetch_array($result);
$dbarray['userid'] = stripslashes($dbarray['userid']);
$userid = stripslashes($userid);

/* Validate that userid is correct */
if($userid == $dbarray['userid']){
return 0; //Success! Username and userid confirmed
}
else{
return 2; //Indicates userid invalid
}
}

/**
* usernameTaken - Returns true if the username has
* been taken by another user, false otherwise.
*/
function usernameTaken($username){
if(!get_magic_quotes_gpc()){
$username = addslashes($username);
}
$q = "SELECT username FROM ".TBL_USERS." WHERE username = '$username'";
$result = mysql_query($q, $this->connection);
return (mysql_numrows($result) > 0);
}

/**
* usernameBanned - Returns true if the username has
* been banned by the administrator.
*/
function usernameBanned($username){
if(!get_magic_quotes_gpc()){
$username = addslashes($username);
}
$q = "SELECT username FROM ".TBL_BANNED_USERS." WHERE username = '$username'";
$result = mysql_query($q, $this->connection);
return (mysql_numrows($result) > 0);
}

/**
* addNewUser - Inserts the given (username, password, email)
* info into the database. Appropriate user level is set.
* Returns true on success, false otherwise.
*/
function addNewUser($username, $password, $email){
$time = time();
/* If admin sign up, give admin user level */
if(strcasecmp($username, ADMIN_NAME) == 0){
$ulevel = ADMIN_LEVEL;
}else{
$ulevel = USER_LEVEL;
}
$q = "INSERT INTO ".TBL_USERS." VALUES ('$username', '$password', '0', $ulevel, '$email', $time)";
return mysql_query($q, $this->connection);
}

/**
* updateUserField - Updates a field, specified by the field
* parameter, in the user's row of the database.
*/
function updateUserField($username, $field, $value){
$q = "UPDATE ".TBL_USERS." SET ".$field." = '$value' WHERE username = '$username'";
return mysql_query($q, $this->connection);
}

/**
* getUserInfo - Returns the result array from a mysql
* query asking for all information stored regarding
* the given username. If query fails, NULL is returned.
*/
function getUserInfo($username){
$q = "SELECT * FROM ".TBL_USERS." WHERE username = '$username'";
$result = mysql_query($q, $this->connection);
/* Error occurred, return given name by default */
if(!$result || (mysql_numrows($result) < 1)){
return NULL;
}
/* Return result array */
$dbarray = mysql_fetch_array($result);
return $dbarray;
}

/**
* getNumMembers - Returns the number of signed-up users
* of the website, banned members not included. The first
* time the function is called on page load, the database
* is queried, on subsequent calls, the stored result
* is returned. This is to improve efficiency, effectively
* not querying the database when no call is made.
*/
function getNumMembers(){
if($this->num_members < 0){
$q = "SELECT * FROM ".TBL_USERS;
$result = mysql_query($q, $this->connection);
$this->num_members = mysql_numrows($result);
}
return $this->num_members;
}

/**
* calcNumActiveUsers - Finds out how many active users
* are viewing site and sets class variable accordingly.
*/
function calcNumActiveUsers(){
/* Calculate number of users at site */
$q = "SELECT * FROM ".TBL_ACTIVE_USERS;
$result = mysql_query($q, $this->connection);
$this->num_active_users = mysql_numrows($result);
}

/**
* calcNumActiveGuests - Finds out how many active guests
* are viewing site and sets class variable accordingly.
*/
function calcNumActiveGuests(){
/* Calculate number of guests at site */
$q = "SELECT * FROM ".TBL_ACTIVE_GUESTS;
$result = mysql_query($q, $this->connection);
$this->num_active_guests = mysql_numrows($result);
}

/**
* addActiveUser - Updates username's last active timestamp
* in the database, and also adds him to the table of
* active users, or updates timestamp if already there.
*/
function addActiveUser($username, $time){
$q = "UPDATE ".TBL_USERS." SET timestamp = '$time' WHERE username = '$username'";
mysql_query($q, $this->connection);

if(!TRACK_VISITORS) return;
$q = "REPLACE INTO ".TBL_ACTIVE_USERS." VALUES ('$username', '$time')";
mysql_query($q, $this->connection);
$this->calcNumActiveUsers();
}

/* addActiveGuest - Adds guest to active guests table */
function addActiveGuest($ip, $time){
if(!TRACK_VISITORS) return;
$q = "REPLACE INTO ".TBL_ACTIVE_GUESTS." VALUES ('$ip', '$time')";
mysql_query($q, $this->connection);
$this->calcNumActiveGuests();
}

/* These functions are self explanatory, no need for comments */

/* removeActiveUser */
function removeActiveUser($username){
if(!TRACK_VISITORS) return;
$q = "DELETE FROM ".TBL_ACTIVE_USERS." WHERE username = '$username'";
mysql_query($q, $this->connection);
$this->calcNumActiveUsers();
}

/* removeActiveGuest */
function removeActiveGuest($ip){
if(!TRACK_VISITORS) return;
$q = "DELETE FROM ".TBL_ACTIVE_GUESTS." WHERE ip = '$ip'";
mysql_query($q, $this->connection);
$this->calcNumActiveGuests();
}

/* removeInactiveUsers */
function removeInactiveUsers(){
if(!TRACK_VISITORS) return;
$timeout = time()-USER_TIMEOUT*60;
$q = "DELETE FROM ".TBL_ACTIVE_USERS." WHERE timestamp < $timeout";
mysql_query($q, $this->connection);
$this->calcNumActiveUsers();
}

/* removeInactiveGuests */
function removeInactiveGuests(){
if(!TRACK_VISITORS) return;
$timeout = time()-GUEST_TIMEOUT*60;
$q = "DELETE FROM ".TBL_ACTIVE_GUESTS." WHERE timestamp < $timeout";
mysql_query($q, $this->connection);
$this->calcNumActiveGuests();
}

/**
* query - Performs the given query on the database and
* returns the result, which may be false, true or a
* resource identifier.
*/
function query($query){
return mysql_query($query, $this->connection);
}
};

/* Create database connection */
$database = new MySQLDB;

?> 

[Artur]

däe det står $this->connection = mysql_connect(DB_SERVER, DB_USER, DB_PASS jag har fyllt i DB server DB user och DBpass

[Jonas__B]

$this->connection = mysql_connect("mysql.domän.se", "myuseruser", "mittlösenord")

 

har du fyllt i som strängar??

[Artur]

Nej, ska prova detta, återkommer efter jag har provat

[Artur]

Vad är strängar? Har aldrig hållt på med PHP och SQL

[Jonas__B]

$variabel1 = "jag har fnuttar runt om mig, därför är jag en sträng";

$variabel2 = 123; //endast siffror därför typen "int"

 

Detta är enkelt uttryckt. Sedan kan man type-cast:a.

 

googla på "php variables"

[Artur]

ok, men kan nån hjälpa mig att fixa problemet?

[EkaErik]

Så det funkade inte att lägga fnuttar " " omkring DB_SERVER, DB_USER, DB_PASS på rad 24 som Jonas_B skrev?

[Jonas__B]

Ok, men byter du ut med de riktiga uppgifterna?

Dvs databasserver, databasanvändare samt lösenord?

[Artur]

Tack för tipset, ska prova om det fungerar

[Artur]

Japp det felet är löst, men nu står det Warning: mysql_connect() [function.mysql-connect]: Host 'srv39.000webhost.com' is not allowed to connect to this MySQL server in /home/a1532196/public_html/include/database.php on line 24

[EkaErik]

Då har du fel server, användarnamn eller lösenord (på samma rad som tidigare). Antagligen användarnamn / lösenord som inte stämmer. Men du behöver kontrollera alla.

[Artur]

nu hänger jag inte alls med, jag skickar koden som den ser ut nu, sen hoppas jag att nån kan fixa till koden och skicka tillbaka den

[EkaErik]

däe det står $this->connection = mysql_connect(DB_SERVER, DB_USER, DB_PASS jag har fyllt i DB server DB user och DBpass

 

mm, fast det är i denna grej som din kod strular. Vi vet inte server, user eller pass... Men det verkar som du skrivit in fel info då felmeddelandet säger att det är just här som den hittar problem och dör.

[Artur]

Engilt 000webhost behöver man lägga till följande.

 

$mysql_host = "databasen.domän.se";$mysql_database = "databasnamnet";$mysql_user = "databas_anvandare";$mysql_password = "123123";

Sha jag prova det?

[Jonas__B]

Mindre bra att du skriver ut de fullständiga uppgifterna, så ändra det.

 

Ja du har du uppgifterna så ändra mysql_connect-raden med dina uppgifter

[Artur]

Har lagt ner detta jobb, håller nu på att lära mig php, så kan jag göra ett eget

[EkaErik]

Jag tror det kan vara en bra idé, skummade igenom den kod du bifogade och det verkar ett knepigt sätt att lösa enkla grejer. Eller, de grejer man oftast behöver inom PHP / MySQL är relativt enkla att skriva själv. Den kod du skrev var onödigt trixig sålänge man inte gör en ny form av databashanterare, vilket oftast inte är nödvändigt.